Skip to content

test: simpler checker no-op for grammar #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lengau wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test: simpler checker no-op for grammar #899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions craft_application/grammar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,18 +123,11 @@ def process_parts(

:returns: The processed parts data.
"""

def self_check(value: Any) -> bool: # noqa: ANN401
return bool(
value == value # pylint: disable=comparison-with-itself # noqa: PLR0124
)

# TODO: make checker optional in craft-grammar. # noqa: FIX002
processor = GrammarProcessor(
arch=arch,
target_arch=target_arch,
platforms=platform_ids,
checker=self_check,
checker=lambda _: True,
)

for part_name, part_data in parts_yaml_data.items():
Expand Down