-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ds-core-form): boilerplate pt 4 #167
base: main
Are you sure you want to change the base?
Conversation
Points of interest for an initial review :
|
{...register(name, registerProps)} | ||
/> | ||
<output htmlFor={id} className="ds range-output"> | ||
{value} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the output is currently empty until the user changes the slider value (no initial value is loaded).
Even when I modified the range story to use a pre-filled value, the output was not populated until after I interacted with the form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
a dictionary of defaultValues
needs to be provided to the Form
at instantiation - see the story on the latest commit for an example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a dictionary of defaultValues
needs to be provided to the Form
at instantiation - see the story on the latest commit for an example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I was consuming the form in an unintended way I think:
<Field type="range" value={3}/>
value
is valid here as it comes from the InputElement props. You may want to disallow that prop if we don't intend for the field to be used in this way.
Done
useOptionAriaProperties
hook in an initial stageuseFieldAriaProperties
call ofuseId
export type TextareaProps = BaseInputProps & React.HTMLProps<HTMLTextAreaElement>;
)QA
PR readiness check
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
:check
,check:fix
, andtest
.build
.