Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon components as SVG imports #70

Closed
wants to merge 2 commits into from
Closed

Icon components as SVG imports #70

wants to merge 2 commits into from

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Dec 11, 2024

Done

Adds POC of icon components implemented as imported SVGs and exported as separate component per icon.

QA

  • [Add QA steps]

PR readiness check

  • PR should have one of the following labels:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • All packages define the required scripts in package.json:
    • All packages: check and check:fix.
    • Packages with a build step: build.

Screenshots

[if relevant, include a screenshot or screen capture]

@advl
Copy link
Contributor

advl commented Dec 18, 2024

Closed to prefer the non-loader approach used in #78

@advl advl closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants