Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag with charm name to dashboard #390

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Add tag with charm name to dashboard #390

merged 3 commits into from
Feb 10, 2025

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Feb 7, 2025 •
edited
Loading

Issue

  • Sometimes it's not obvious where a given dashboard originated from.
  • When browsing list of dashboards in grafana UI, it could be handy to filter by charm name.

Solution

Have the Provider auto-add a tag with the charm's name, if it is not already there.
In tandem with canonical/grafana-agent-operator#256.

Fixes #368.

Context

Testing Instructions

See canonical/grafana-agent-operator#256.

Upgrade Notes

@sed-i sed-i mentioned this pull request Feb 7, 2025
Merged
@sed-i sed-i marked this pull request as ready for review February 7, 2025 19:30
@sed-i sed-i requested a review from a team as a code owner February 7, 2025 19:30
@sed-i sed-i merged commit 6786d77 into main Feb 10, 2025
28 checks passed
@sed-i sed-i deleted the feature/charm_tag branch February 10, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucabello lucabello lucabello approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dashboard tag for charm name if it is missing
2 participants
@sed-i @lucabello