feat: add role-assignment requirer integration#72
Draft
gboutry wants to merge 2 commits intocanonical:mainfrom
Draft
feat: add role-assignment requirer integration#72gboutry wants to merge 2 commits intocanonical:mainfrom
gboutry wants to merge 2 commits intocanonical:mainfrom
Conversation
gboutry
force-pushed
the
feat/role-assignment
branch
from
e91f3f2 to
cf6b237
Compare
crypticC0der
requested changes
Mar 30, 2026
Collaborator
crypticC0der
left a comment
crypticC0der
left a comment
There was a problem hiding this comment.
can you also rebase this onto main (8cc5aa8)
Contributor
Author
gboutry
force-pushed
the
feat/role-assignment
branch
2 times, most recently
from
5158433 to
a790767
Compare
Collaborator
This allows the integration tests to invoke snaps (such as juju). In more recent versions of TOX, all environment variables are cut off from the subprocess invokation. Signed-off-by: Guillaume Boutry <guillaume.boutry@canonical.com>
Add RoleHandler that integrates with the role-distributor charm via the role-assignment relation. Roles use MicroOVN taxonomy: central (OVN central services), chassis (data plane), and gateway. Key design decisions: - Role assignment is a durable source of truth, re-evaluated on update-status, ovsdb-cms ready/broken, and cluster-changed events. - Applied roles are cached in StoredState for idempotency; the cache is invalidated when _dataplane_mode() mutates central outside RoleHandler. - Gateway config reads fail closed: transient ovs-vsctl failures block rather than clobbing existing ovn-cms-options from an assumed-empty value. - Relation broken keeps workload state unchanged but clears the cache and recomputes unit status. - The relation is optional; backward compatibility is preserved when no role-assignment relation exists. Assisted-By: Claude Code (claude-opus-4-6) Assisted-By: Codex (gpt-5.4-xhigh) Signed-off-by: Guillaume Boutry <guillaume.boutry@canonical.com>
gboutry
force-pushed
the
feat/role-assignment
branch
from
a790767 to
6228bd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RoleHandler that integrates with the role-distributor charm via the role-assignment relation. Roles use MicroOVN taxonomy: central (OVN central services), chassis (data plane), and gateway.
Key design decisions:
Requires: