Skip to content

Update DPU detection logic.#318

Merged
fnordahl merged 2 commits intocanonical:mainfrom
crypticC0der:dpulogic
Mar 20, 2026
Merged

Update DPU detection logic.#318
fnordahl merged 2 commits intocanonical:mainfrom
crypticC0der:dpulogic

Conversation

@crypticC0der
Copy link
Contributor

@crypticC0der crypticC0der commented Mar 17, 2026

In recent research with real hardware we have found our previous assumptions to be incorrect, so we are updating it to be controller = 1 and pcipf OR pcivf in the devlink port output 0 1.

@crypticC0der crypticC0der requested a review from a team as a code owner March 17, 2026 09:50
@crypticC0der crypticC0der force-pushed the dpulogic branch 2 times, most recently from 1783918 to f588621 Compare March 17, 2026 10:20
In recent research with real hardware we have found our previous
assumptions to be incorrect, so we are updating it to be controller = 1
and pcipf OR pcivf in the devlink port output[0].

[0]: https://docs.kernel.org/networking/devlink/devlink-port.html

Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
@fnordahl
Copy link
Member

@crypticC0der the dqlite build error persists, I also checked on main branch. From my perspective this is likely technical debt in dqlite, which has now been forced into error by toolchain changes in resolute.

To unblock this a tactical approach could be:

  • Raise an issue with dqlite.
  • Reference said issue in snap/snapcraft.yaml as we add CFLAGS: -Wno-error=discarded-qualifiers to build-environment in the dqlite part.

Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
@crypticC0der
Copy link
Contributor Author

Raise an issue with dqlite.

Why raise an issue when you can raise a PR

@crypticC0der
Copy link
Contributor Author

the snapcraft change is based on not having this merged canonical/dqlite#875, so when it gets merged and added in a release we can remove it which will be nice

@fnordahl
Copy link
Member

Intriguing, now we have a Go crash fatal error: concurrent map writes (LP#2144984). Unsure if this is the source of the intermittent failure of the upgrade test, or if it goes in hand with toolchain and/or dqlite changes.

@fnordahl
Copy link
Member

Intriguing, now we have a Go crash fatal error: concurrent map writes (LP#2144984). Unsure if this is the source of the intermittent failure of the upgrade test, or if it goes in hand with toolchain and/or dqlite changes.

Given it just passed after another retry it is likely this is the source of the intermittent test failure \o/. Let's deal with that separately though.

@fnordahl
Copy link
Member

Also, LP#2144987

Copy link
Member

@fnordahl fnordahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fnordahl fnordahl merged commit f9b630b into canonical:main Mar 20, 2026
184 of 210 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants