chore: update jujuversion import #644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
=======================================
Coverage 70.67% 70.67%
=======================================
Files 11 11
Lines 2933 2933
Branches 512 512
=======================================
Hits 2073 2073
Misses 750 750
Partials 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Dear @IronCore864 , it is still a draft PR, please click "Ready for review" button to proceed further. P.S. Thank you for contribution! |
|
The charm should be using the correct way to check the version now. Closing since the PR drifted away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#640
Solution
See more detail in the issue, but sorry to bother you again, because after discussion, we will change
ops.jujuversionas well, so my previous PR won't work in the future, and now I'm creating a new PR to fix it once and for all.