Rocks 2419/allow single char names#957
Merged
tigarmo merged 7 commits intocanonical:mainfrom Sep 11, 2025
Merged
Conversation
lengau
reviewed
Sep 9, 2025
lengau
reviewed
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make lint && make test?This PR allows rockcraft to produce Rocks with less than three characters in the name by removing such restriction in
rockcraftand using the one from parent class incraft-application. To prevent the resulting pebble layer to fail the validation, a-rockcraft-prefix is automatically added to the layer name.Related PR
canonical/craft-application#894
Context: Although rockcraft itself will allow names with a single character, it will fail the validation for
title. This is because whentitleis not set, Rockcraft will set thetitlevalue to be equal to thename. However,titlehas amin_lengthof2whilenamehas a min length of1. The PR above aims to fix this situation.