Rename "Validator faucet cap" UI label to "Validator liveness reward cap"#5249
Open
samsondav wants to merge 1 commit intocanton-network:mainfrom
Open
Conversation
github-actions
Bot
assigned
isegall-da,
martinflorian-da,
rautenrieth-da and
ray-roestenburg-da
…cap" Aligns user-facing terminology with the Canton Coin whitepaper, which uses "liveness rewards" rather than "faucet" for these per-round validator rewards. Per issue canton-network#958, scope is limited to user-visible text and a stale Daml docstring; the underlying Daml templates and ABI fields are kept as-is to preserve on-chain compatibility (the new ValidatorLivenessActivityRecord template already exists alongside the deprecated ValidatorFaucetCoupon). - apps/sv/frontend: relabel the optValidatorFaucetCap config rows in the SV governance minting curve diff view, and add a unit-test assertion pinning the new initial-value and step labels. - splice-amulet/ValidatorLicense.daml: fix the ValidatorLicense_ReportActive docstring to reference the current ValidatorLicense_RecordValidatorLivenessActivity choice (instead of the deprecated ReceiveFaucetCoupon) and to contrast enabled vs disabled wallets in parallel with the line above. Fixes canton-network#958 Signed-off-by: Sam Davies <[email protected]>
samsondav
force-pushed
the
sam-avro/issue-958-faucet-liveness-ui-labels
branch
from
e5131ee to
2f42ded
Compare
samsondav
force-pushed
the
sam-avro/issue-958-faucet-liveness-ui-labels
branch
from
2f42ded to
cfd41b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns user-facing terminology with the Canton Coin whitepaper, which uses "liveness rewards" rather than "faucet" for the per-round validator rewards. Fixes #958.
apps/sv/frontend: relabel the twooptValidatorFaucetCaprows in the SV governance minting curve diff view ("Validator faucet cap" → "Validator liveness reward cap"). Adds a unit test pinning both new labels.splice-amulet/ValidatorLicense.daml: fix theValidatorLicense_ReportActivedocstring to reference the currentValidatorLicense_RecordValidatorLivenessActivitychoice (instead of the deprecatedReceiveFaucetCoupon) and to contrast enabled vs disabled wallets in parallel with the line above.Scope
Per the original issue author's guidance ("No changes to Daml code; just UI for now"), this is intentionally minimal:
ValidatorLivenessActivityRecordtemplate already exists alongside the deprecatedValidatorFaucetCoupon; the wallet OpenAPI already exposes both endpoint sets. RenamingFaucetState,optValidatorFaucetCap,optIssuancePerValidatorFaucetCoupon, etc. would break on-chain contract compatibility for fields still in active templates and is out of scope./v0/validators/validator-faucets,/v0/top-validators-by-validator-faucets) are unchanged here. Adding a parallel "liveness" set (mirroring what was done for the wallet API) would be a reasonable follow-up but is a separate concern from a label rename.ReceiveFaucetCouponTrigger,listValidatorFaucetCouponsOnDomain) still process the deprecatedValidatorFaucetCoupontemplate — their names accurately describe what they do. They can be revisited if/when the deprecated template is removed.Test plan
vitest --runinapps/sv/frontend): 200/200 tests pass, including the new label-pinning assertion.daml buildonsplice-amulet: succeeds (comment-only Daml change is a no-op).buildAmuletConfigChangesandbuildAmuletRulesConfigFromChangestest suites pass; the test-fixture strings inbuildAmuletRulesConfigFromChanges.test.ts("Opt Validator Faucet Cap") are auto-generated synthetic labels mirroring the still-unchanged Daml field name and are intentionally left alone.