Skip to content

Perform activity totals and root-hash calculations for rounds with zero activity#5278

Open
adetokunbo wants to merge 1 commit intoadetokunbo/cip-104-sv-app-rewards-integrate-reward-computation-triggerfrom
adetokunbo/cip-104-trigger-should-not-assume-all-rounds-non-empty
Open

Perform activity totals and root-hash calculations for rounds with zero activity#5278
adetokunbo wants to merge 1 commit intoadetokunbo/cip-104-sv-app-rewards-integrate-reward-computation-triggerfrom
adetokunbo/cip-104-trigger-should-not-assume-all-rounds-non-empty

Conversation

@adetokunbo
Copy link
Copy Markdown
Contributor

Fixes #5186
Stacked on #5119

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@adetokunbo adetokunbo self-assigned this Apr 28, 2026
Copy link
Copy Markdown
Contributor

@dfordivam dfordivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adetokunbo adetokunbo force-pushed the adetokunbo/cip-104-trigger-should-not-assume-all-rounds-non-empty branch from a6ba56d to a8e9732 Compare April 30, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants