Add physical synchronizer id to periodic topology snapshot metadata#5337
Open
thibault-da wants to merge 3 commits intocanton-network:mainfrom
Open
Add physical synchronizer id to periodic topology snapshot metadata#5337thibault-da wants to merge 3 commits intocanton-network:mainfrom
thibault-da wants to merge 3 commits intocanton-network:mainfrom
Conversation
Contributor
|
@thibault-da can you rebase on latest Splice main? We've had to make some changes following the move of Splice to CF. Thanks |
ada1a77 to
b141b12
Compare
Author
|
@isegall-da done :) |
moritzkiefer-da
previously approved these changes
May 4, 2026
| metadata = summary.map(e => | ||
| (e._1.code, e._2.toString) | ||
| ) + ("sequencerId" -> sequencerId.toProtoPrimitive) | ||
| metadataMap = summary.map(e => (e._1.code, e._2.toString)) + |
Contributor
There was a problem hiding this comment.
nit: feels like a pretty weird csv file. instead of having headers at the top we instead have each row be a key value pair. How do you feel about making it a json file?
Contributor
|
CI doesn't like your change: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need the physical synchronizer Id the snapshot was taken from to correctly validate it in canton CI tests.
This PR adds it to the existing metadata file.
It also writes in a CSV-style format instead of
toStringthe map which resulted in a not so nice to parseHashMap(key -> value)contentPull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines