Skip to content

Allow overriding vars in the private envrc.vars#5394

Open
nicu-da wants to merge 1 commit intomainfrom
nicuda/chore/fix_sourcing
Open

Allow overriding vars in the private envrc.vars#5394
nicu-da wants to merge 1 commit intomainfrom
nicuda/chore/fix_sourcing

Conversation

@nicu-da
Copy link
Copy Markdown
Contributor

@nicu-da nicu-da commented May 5, 2026

Fixes issues where not sourcing the private vars before loading nix loads the oss edition

[ci]

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Fixes issues where not sourcing the private vars before loading nix loads the oss edition

[ci]

Signed-off-by: Nicu Reut <[email protected]>
Copy link
Copy Markdown
Contributor

@moritzkiefer-da moritzkiefer-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it may work thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants