Skip to content

fix: rename JsCommands to Commands #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexmatson-da merged 1 commit into from
May 20, 2026
Merged

fix: rename JsCommands to Commands #1833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions api-specs/openrpc-dapp-api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@
"$ref": "api-specs/openrpc-dapp-api.json#/components/schemas/CommandId"
},
"commands": {
"$ref": "api-specs/openrpc-dapp-api.json#/components/schemas/JsCommands"
"$ref": "api-specs/openrpc-dapp-api.json#/components/schemas/Commands"
},
"actAs": {
"title": "actAs",
Expand Down Expand Up @@ -409,8 +409,8 @@
}
]
},
"JsCommands": {
"title": "JsCommands",
"Commands": {
"title": "Commands",
"type": "array",
"minItems": 1,
"description": "Non-empty array of Daml command atoms to submit atomically as a single transaction.",
Expand Down
4 changes: 2 additions & 2 deletions core/wallet-dapp-remote-rpc-client/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export type Command =
* Non-empty array of Daml command atoms to submit atomically as a single transaction.
*
*/
export type JsCommands = Command[]
export type Commands = Command[]
/**
*
* The party that signed the transaction.
Expand Down Expand Up @@ -509,7 +509,7 @@ export interface MessageSignatureFailedEvent {
*/
export interface PrepareExecuteParams {
commandId?: CommandId
commands: JsCommands
commands: Commands
actAs?: ActAs
readAs?: ReadAs
disclosedContracts?: DisclosedContracts
Expand Down
4 changes: 2 additions & 2 deletions core/wallet-dapp-rpc-client/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export type Command =
* Non-empty array of Daml command atoms to submit atomically as a single transaction.
*
*/
export type JsCommands = Command[]
export type Commands = Command[]
/**
*
* The party that signed the transaction.
Expand Down Expand Up @@ -501,7 +501,7 @@ export interface MessageSignatureFailedEvent {
*/
export interface PrepareExecuteParams {
commandId?: CommandId
commands: JsCommands
commands: Commands
actAs?: ActAs
readAs?: ReadAs
disclosedContracts?: DisclosedContracts
Expand Down
6 changes: 3 additions & 3 deletions core/wallet-dapp-rpc-client/src/openrpc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@
"$ref": "api-specs/openrpc-dapp-api.json#/components/schemas/CommandId"
},
"commands": {
"$ref": "api-specs/openrpc-dapp-api.json#/components/schemas/JsCommands"
"$ref": "api-specs/openrpc-dapp-api.json#/components/schemas/Commands"
},
"actAs": {
"title": "actAs",
Expand Down Expand Up @@ -409,8 +409,8 @@
}
]
},
"JsCommands": {
"title": "JsCommands",
"Commands": {
"title": "Commands",
"type": "array",
"minItems": 1,
"description": "Non-empty array of Daml command atoms to submit atomically as a single transaction.",
Expand Down
4 changes: 2 additions & 2 deletions sdk/dapp-sdk/src/dapp-api/rpc-gen/typings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export type Command =
* Non-empty array of Daml command atoms to submit atomically as a single transaction.
*
*/
export type JsCommands = Command[]
export type Commands = Command[]
/**
*
* The party that signed the transaction.
Expand Down Expand Up @@ -500,7 +500,7 @@ export interface MessageSignatureFailedEvent {
*/
export interface PrepareExecuteParams {
commandId?: CommandId
commands: JsCommands
commands: Commands
actAs?: ActAs
readAs?: ReadAs
disclosedContracts?: DisclosedContracts
Expand Down
4 changes: 2 additions & 2 deletions wallet-gateway/extension/src/dapp-api/rpc-gen/typings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export type Command =
* Non-empty array of Daml command atoms to submit atomically as a single transaction.
*
*/
export type JsCommands = Command[]
export type Commands = Command[]
/**
*
* The party that signed the transaction.
Expand Down Expand Up @@ -500,7 +500,7 @@ export interface MessageSignatureFailedEvent {
*/
export interface PrepareExecuteParams {
commandId?: CommandId
commands: JsCommands
commands: Commands
actAs?: ActAs
readAs?: ReadAs
disclosedContracts?: DisclosedContracts
Expand Down
4 changes: 2 additions & 2 deletions wallet-gateway/remote/src/dapp-api/rpc-gen/typings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export type Command =
* Non-empty array of Daml command atoms to submit atomically as a single transaction.
*
*/
export type JsCommands = Command[]
export type Commands = Command[]
/**
*
* The party that signed the transaction.
Expand Down Expand Up @@ -508,7 +508,7 @@ export interface MessageSignatureFailedEvent {
*/
export interface PrepareExecuteParams {
commandId?: CommandId
commands: JsCommands
commands: Commands
actAs?: ActAs
readAs?: ReadAs
disclosedContracts?: DisclosedContracts
Expand Down
4 changes: 2 additions & 2 deletions wallet-gateway/remote/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { v4 } from 'uuid'
import { LedgerClient, Types } from '@canton-network/core-ledger-client'
import type {
DisclosedContracts,
JsCommands,
Commands,
PackageIdSelectionPreference,
} from './dapp-api/rpc-gen/typings.js'

Expand Down Expand Up @@ -34,7 +34,7 @@ export async function networkStatus(

export interface PrepareParams {
commandId?: string
commands?: JsCommands
commands?: Commands
actAs?: string[]
readAs?: string[]
disclosedContracts?: DisclosedContracts
Expand Down