Skip to content

test(core-acs-reader): add unit tests#1924

Merged
mateuszpiatkowski-da merged 17 commits into
mainfrom
mateuszpiatkowski-da/core-acs-reader-unit-tests
Jun 17, 2026
Merged

test(core-acs-reader): add unit tests#1924
mateuszpiatkowski-da merged 17 commits into
mainfrom
mateuszpiatkowski-da/core-acs-reader-unit-tests

Conversation

@mateuszpiatkowski-da

@mateuszpiatkowski-da mateuszpiatkowski-da commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@mateuszpiatkowski-da mateuszpiatkowski-da self-assigned this Jun 1, 2026
@mateuszpiatkowski-da mateuszpiatkowski-da linked an issue Jun 1, 2026 that may be closed by this pull request
core-acs-reader unit tests #1863
Closed
@mateuszpiatkowski-da mateuszpiatkowski-da marked this pull request as ready for review June 1, 2026 13:19
@mateuszpiatkowski-da mateuszpiatkowski-da requested a review from a team as a code owner June 1, 2026 13:19
pawelstepien-da
pawelstepien-da reviewed Jun 2, 2026
View reviewed changes
Comment thread core/acs-reader/src/cache/__test__/cache.test.ts Outdated
pawelstepien-da
pawelstepien-da reviewed Jun 2, 2026
View reviewed changes
Comment thread core/acs-reader/src/cache/__test__/cache.test.ts Outdated
pawelstepien-da
pawelstepien-da reviewed Jun 2, 2026
View reviewed changes
Comment thread core/acs-reader/src/cache/__test__/cache.test.ts Outdated
pawelstepien-da
pawelstepien-da reviewed Jun 2, 2026
View reviewed changes
Comment thread core/acs-reader/src/cache/__test__/collection.test.ts Outdated
@pawelstepien-da

pawelstepien-da commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Please also set coverage thresholds in vitest.config.ts to 70% branches and 80% other metrics.

@mateuszpiatkowski-da

mateuszpiatkowski-da commented Jun 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Converting to draft since #1947 should be merged first as it will make substantial changes to code structure.

@mateuszpiatkowski-da mateuszpiatkowski-da marked this pull request as draft June 6, 2026 18:47
@mateuszpiatkowski-da mateuszpiatkowski-da mentioned this pull request Jun 8, 2026
Merged
@mateuszpiatkowski-da
test(core-acs-reader): add cache test
fb208cc 
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@mateuszpiatkowski-da
test(core-acs-reader): add collection tests
35dde8b 
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@mateuszpiatkowski-da
test(core-acs-reader): add reader tests
30f4e4f 
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@mateuszpiatkowski-da
test(core-acs-reader): add test for service
2eb3fea 
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@mateuszpiatkowski-da
fix(core-acs-reader): undo vitest config modification
f02745e 
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@mateuszpiatkowski-da
test(core-acs-reader): remove redundant test
e9363ac 
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@mateuszpiatkowski-da
test(core-acs-reader): add tests for collection & cache items
7531418 
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@mateuszpiatkowski-da
test(core-acs-reader): continue working on tests :wip:
43b90e4 
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@mateuszpiatkowski-da
test(core-acs-reader): finish working on tests
646b89d 
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@mateuszpiatkowski-da mateuszpiatkowski-da force-pushed the mateuszpiatkowski-da/core-acs-reader-unit-tests branch from dcb2614 to 646b89d Compare June 11, 2026 09:58
@mateuszpiatkowski-da mateuszpiatkowski-da marked this pull request as ready for review June 11, 2026 09:58
@mateuszpiatkowski-da mateuszpiatkowski-da enabled auto-merge (squash) June 11, 2026 09:59
alexmatson-da
alexmatson-da previously approved these changes Jun 12, 2026
View reviewed changes
@mateuszpiatkowski-da
refactor(core-acs-reader): remove redundant flags
cc6cfb6 
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@mateuszpiatkowski-da
refactor(wallet-sdk): remove redundant method
cc8d5fd 
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
pawelstepien-da
pawelstepien-da reviewed Jun 16, 2026
View reviewed changes
Comment thread core/acs-reader/src/__test__/cache/collection.test.ts
@mateuszpiatkowski-da
test(core-acs-reader): add additional test assertion
e2f83ab 
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@pawelstepien-da pawelstepien-da self-requested a review June 16, 2026 19:02
pawelstepien-da
pawelstepien-da reviewed Jun 16, 2026
View reviewed changes

@pawelstepien-da pawelstepien-da left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something makes running yarn test:coverage in that package keep on running forever. I tried locally and it seems that it happens only when tests run in environment browser. I'm not sure if that core package is supposed to be node only, but if not then I suspect it may be caused by importOriginal. If it's only for node, then remove vitest project browser.

@mateuszpiatkowski-da
test(core-acs-reader): fix test build
9961dee 
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
@mateuszpiatkowski-da

mateuszpiatkowski-da commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Something makes running yarn test:coverage in that package keep on running forever. I tried locally and it seems that it happens only when tests run in environment browser. I'm not sure if that core package is supposed to be node only, but if not then I suspect it may be caused by importOriginal. If it's only for node, then remove vitest project browser.

fixed!

@mateuszpiatkowski-da mateuszpiatkowski-da enabled auto-merge (squash) June 17, 2026 12:17
@mateuszpiatkowski-da mateuszpiatkowski-da merged commit 74d1b8c into main Jun 17, 2026
28 checks passed
@mateuszpiatkowski-da mateuszpiatkowski-da deleted the mateuszpiatkowski-da/core-acs-reader-unit-tests branch June 17, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawelstepien-da pawelstepien-da pawelstepien-da left review comments

@alexmatson-da alexmatson-da alexmatson-da approved these changes

Assignees

@mateuszpiatkowski-da mateuszpiatkowski-da

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

core-acs-reader unit tests

3 participants

@mateuszpiatkowski-da @pawelstepien-da @alexmatson-da