test: dapp-sdk unit tests#1992
Merged
Merged
Conversation
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
Closed
alexmatson-da
previously approved these changes
Jun 15, 2026
mateuszpiatkowski-da
left a comment
mateuszpiatkowski-da
left a comment
Contributor
There was a problem hiding this comment.
To be continued 😝
Signed-off-by: Pawel Stepien <pawel.stepien@digitalasset.com>
mateuszpiatkowski-da
approved these changes
Jun 17, 2026
mateuszpiatkowski-da
left a comment
mateuszpiatkowski-da
left a comment
Contributor
There was a problem hiding this comment.
Basically 99% of the comments (if not all of them) are improvements, hence the ✅ . I suppose it would be nice to look into them though in a separate improvement task :)
Contributor
|
All comments included in #2027 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
dapp-sdk integration tests run together with units on yarn test / test:coverage, but only unit tests count to coverage.