Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multitenancy: Tenant specific object store instance support #159

Open
wants to merge 73 commits into
base: main
Choose a base branch
from
Open

Multitenancy: Tenant specific object store instance support #159

wants to merge 73 commits into from

Conversation

KritiShekhar
Copy link
Collaborator

@KritiShekhar KritiShekhar commented Mar 10, 2025 •
edited by jeevitha011
Loading

  • Remove hardcoded service plan name after review
  • Test single tenant application
  • Test multitenant application with shared object store instance
  • Test multitenant application with separate object store instance

@KritiShekhar
adding subscribe and unsubscribe handler
e211507
@KritiShekhar
refactor of the function calls
1068269
@KritiShekhar
remove mock service manager data
eb04ade
@KritiShekhar
add check to run mtx ,only when application is deployed
c3ab324
@KritiShekhar
console log for debug purpose
e6e72d3
@KritiShekhar
add console log for cds-plugin
cba1dc6
@KritiShekhar
console log for inside subscribe handler
add97a8
@KritiShekhar
plan ID console and right implementation
7904681
@KritiShekhar
plan id console
1ab9ad9
@KritiShekhar
refactored server file
56099b2
@KritiShekhar
changing service_plan_name
91b04c6
@KritiShekhar
code enhancement for object-store-creation
7506c53
@KritiShekhar
token fetch during unsubscibe
6f77808
@KritiShekhar
reverying token fetch code
05959c0
@KritiShekhar
change label query to only query
56fe732
@KritiShekhar
console instance id
72ecc38
@KritiShekhar
change labelquery
e984bba
@KritiShekhar
check if binding id's for deleting the binding or instance is present
2727c83
@KritiShekhar
console for getting binding id status
117b89f
@KritiShekhar
cosnole log statement
58c3411
@KritiShekhar
working code for creating , binding , and deleteing object-store-inst…
b8dbd39 
…ance for multi-tennat app
jeevitha011
jeevitha011 reviewed Mar 10, 2025
View reviewed changes
@jeevitha011 jeevitha011 changed the title Muti-tenant attachments working code base for object store Multitenancy: Tenant specific object store instance support Mar 10, 2025
KritiShekhar and others added 26 commits March 20, 2025 14:51
@KritiShekhar
debug statements instaead of console logs in server.js file
5919d21
@jeevitha011
minor refactor
05d8b4a
@jeevitha011
refactor helper.js
2c5f5a2
@jeevitha011
Merge branch 'main' of https://github.com/cap-js/attachments into mut…
e0e22d5 
…litenancy/attachment
@jeevitha011
refactor mtx/server.js
2a6dd2a
@jeevitha011
minor refactoring
f23e648
@KritiShekhar
changing the version compare for cds
0fd5fbf
@KritiShekhar
adding object store kind(shared by default) in package.json file
21b5cd6
@KritiShekhar
changing the code for cds.version compare for facets
6ca50e7
@KritiShekhar
checking for unsubscribing failing
ddfdbe9
@KritiShekhar
fixing the throw error message to trace unsubscribe failing
cd217ba
@KritiShekhar
changing the throw error code to throw new error
f36ab46
@KritiShekhar
console for checking the binding credentials
62a7495
@KritiShekhar
keep pollUntillDone for getting Binding Id
31a8cd9
@KritiShekhar
remove poll from getting binding Id
ba45ed0
@KritiShekhar
keep check if binding id is null
e10dc92
@KritiShekhar
adding pollUntill for creation , binding and deletion
b6f68d5
@KritiShekhar
fixing the subscribe handler failure for polling
fd0390c
@KritiShekhar
checking response header
7e14223
@KritiShekhar
updating get location for header during binding instance
32effc2
@KritiShekhar
remove polling from bind instance
34a74cd
@KritiShekhar
instead of throwing error adding console.errorr fro printing error
5f39604
@KritiShekhar
add readme , changed log ,comments and some console.error fixes
1535292
@KritiShekhar
change from cosole.error to DEBUG and updation on chnaged log and rea…
e355ab0 
…dme file
@KritiShekhar
updation of changed log and removal of comments where not required
d755c22
@KritiShekhar
enhancement for console.error insted of DEBUG where required
ef758a0
RamIndia
RamIndia reviewed Mar 27, 2025
View reviewed changes
@jeevitha011 jeevitha011 requested a review from danjoa March 28, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RamIndia RamIndia RamIndia left review comments

@jeevitha011 jeevitha011 jeevitha011 requested changes

@danjoa danjoa Awaiting requested review from danjoa

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KritiShekhar @RamIndia @jeevitha011