-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: package-lock maintenance #1113
Open
johannes-vogel
wants to merge
5
commits into
main
Choose a base branch
from
pkglock
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+238
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjoa
approved these changes
Apr 2, 2025
@patricebender @BobdenOs Could one of you have a look at the failing test? I only increased the cds version which seems to lead to a test failure. I'd like to understand why we did not detect this internally. |
I've tracked down the failing test
It produces the following SQL statement: WITH "$A" as (
SELECT *,
'$[' || lpad("$$RN$$", 6, '0') as _path_
FROM (
SELECT *,
ROW_NUMBER() OVER (
ORDER BY ID ASC
) as "$$RN$$"
FROM (
SELECT "$A".name,
"$A".ID,
(
SELECT count(*) as "COUNT"
FROM localized_AdminService_Books as "$B"
inner JOIN "$A" as "$A" ON "$A".ID = "$B".author_ID
####### above inner joins fails, was a where clause before
) as "[email protected]"
FROM AdminService_Authors as "$A"
ORDER BY ID ASC
LIMIT 1000
) as "$A"
) as "$A"
),
"$A_BOOKS" as (
SELECT *,
_parent_path_ || '].books[' || lpad("$$RN$$", 6, '0') as _path_
FROM (
SELECT *,
ROW_NUMBER() OVER (PARTITION BY _parent_path_) as "$$RN$$"
FROM (
SELECT "$B".createdAt,
"$B".createdBy,
"$B".modifiedAt,
"$B".modifiedBy,
"$B".ID,
"$B".title,
"$B".descr,
"$B".author_ID,
"$B".genre_ID,
"$B".stock,
"$B".price,
"$B".currency_code,
"$B".footnotes,
"$B".authorsAddress,
case
when "$B".image IS NULL then ?
else coalesce(?, ?)
end as "[email protected]",
"$A"._path_ as _parent_path_
FROM localized_AdminService_Books as "$B"
inner JOIN "$A" as "$A" ON "$A".ID = "$B".author_ID
) as "$B"
) as "$B"
)
SELECT *
FROM (
SELECT _path_ as "_path_",
'{}' as "_blobs_",
'{"books":[]}' as "_expands_",
(
SELECT name as "name",
ID as "ID",
TO_NVARCHAR("[email protected]") as "[email protected]"
FROM JSON_TABLE(
'{}',
'$' COLUMNS("'$$FaKeDuMmYCoLuMn$$'" FOR ORDINALITY)
) FOR JSON ('format' = 'no', 'omitnull' = 'no', 'arraywrap' = 'no') RETURNS NVARCHAR(2147483647)
) as "_json_"
FROM "$A"
)
UNION ALL
(
SELECT _path_ as "_path_",
'{}' as "_blobs_",
'{}' as "_expands_",
'{"footnotes":' || COALESCE(footnotes, 'null') || ',' || SUBSTRING(
(
SELECT to_char(createdAt, 'YYYY-MM-DD"T"HH24:MI:SS.FF3"Z"') as "createdAt",
createdBy as "createdBy",
to_char(modifiedAt, 'YYYY-MM-DD"T"HH24:MI:SS.FF3"Z"') as "modifiedAt",
modifiedBy as "modifiedBy",
ID as "ID",
title as "title",
descr as "descr",
author_ID as "author_ID",
genre_ID as "genre_ID",
stock as "stock",
TO_NVARCHAR(price) as "price",
currency_code as "currency_code",
authorsAddress as "authorsAddress",
"[email protected]" as "[email protected]"
FROM JSON_TABLE(
'{}',
'$' COLUMNS("'$$FaKeDuMmYCoLuMn$$'" FOR ORDINALITY)
) FOR JSON ('format' = 'no', 'omitnull' = 'no', 'arraywrap' = 'no') RETURNS NVARCHAR(2147483647)
),
2
) as "_json_"
FROM "$A_BOOKS"
)
ORDER BY "_path_" ASC cqn4sql looks ok, does it ring a bell @BobdenOs ? could also be caused by the quoted aliases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.