Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow column names that have to be quoted #1122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

czindel-sap
Copy link

@czindel-sap czindel-sap commented Apr 4, 2025

Following statement should be possible with the proposed change

await INSERT.into ("ENTITY_COL_BEGIN_WITH_NUMBER") .entries ({
  ID: 100,
  "1VALUE": 1,
});

currently this ends up with this error

Error inserting into ENTITY_COL_BEGIN_WITH_NUMBER Error: argument type mismatch: not supported path expression: Support only * or <KEY NAME>
-> $.1VALUE
->   ^

    at Socket.<anonymous> (/Users/D070420/SAPDevelop/cap-dev/node_modules/@sap/hana-client/lib/index.js:53:13)
    at Socket.emit (node:events:520:28)
    at addChunk (node:internal/streams/readable:559:12)
    at readableAddChunkPushByteMode (node:internal/streams/readable:510:3)
    at Readable.push (node:internal/streams/readable:390:5)
    at Pipe.onStreamRead (node:internal/stream_base_commons:191:23)
    at Pipe.callbackTrampoline (node:internal/async_hooks:130:17) {
  code: 293,
  sqlState: 'HY000',
  query: false,
  values: { ID: 100, '1VALUE': 1 }
}

@czindel-sap czindel-sap changed the title Allow column names that have to be quoted fix: Allow column names that have to be quoted Apr 4, 2025
@czindel-sap
Copy link
Author

@johannes-vogel It looks like the tests are not executed or stuck, is there something that I need to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant