Skip to content

chore(cds9): use _target once; no need to drill down manually #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025
Merged

chore(cds9): use _target once; no need to drill down manually #1134

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97b64da
chore(cds9): use `_target` once; no need to drill down
patricebender Apr 9, 2025
64da83c
even simpler now
patricebender Apr 9, 2025
255e395
Merge branch 'main' into patrice/_target
johannes-vogel May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions db-service/lib/cqn4sql.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,11 +802,7 @@ function cqn4sql(originalQuery, model) {
})
} else {
outerAlias = transformedQuery.SELECT.from.as
const getInnermostTarget = q => (q._target ? getInnermostTarget(q._target) : q)
subqueryFromRef = [
...(transformedQuery.SELECT.from.ref || /* subq in from */ [getInnermostTarget(transformedQuery).name]),
...ref,
]
subqueryFromRef = [transformedQuery._target.name, ...ref]
}

// this is the alias of the column which holds the correlated subquery
Expand Down