Java: Document @Capabilities.ExpandRestrictions.*
#1958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoerler
reviewed
Jul 7, 2025
Co-authored-by: Adrian Görler <[email protected]>
beckermarc
reviewed
Jul 10, 2025
| @@ -528,17 +528,29 @@ The total number of request of OData batches can be limited by application confi | |||
|
|
|||
| <div class="impl java"> | |||
|
|
|||
| Settings <Config java>cds.odataV4.batch.maxRequests</Config> resp. <Config java>cds.odataV2.batch.maxRequests</Config> specify the corresponding limits. | |||
| Use settings <Config java>cds.odataV4.batch.maxRequests</Config> resp. <Config java>cds.odataV2.batch.maxRequests</Config> to limit the amount of queries per OData `$batch`. | |||
There was a problem hiding this comment.
The way we have implemented this, it is not really a HTTP Server / Protocol Adapter specific thing, as it also applies on ApplicationService-level. Should we somehow make that clear?
There was a problem hiding this comment.
I wonder if that is more about the runtime than about protocol adapter.
Next chapter?
There was a problem hiding this comment.
The annotations are from OData, so Protocol Adapter section from that perspective makes sense. Maybe we can just mention it in the text?
beckermarc
reviewed
Jul 10, 2025
beckermarc
reviewed
Jul 10, 2025
beckermarc
approved these changes
Jul 10, 2025
agoerler
approved these changes
Jul 11, 2025
|
NB: The feature will be released in 4.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentions
@Capabilities.ExpandRestrictions.*.I wonder if that is more about the runtime than about protocol adapter.