[cds^9] cds.middlewares.after + PATCH vs. PUT vs. Replace + Base Protocol Adapter #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 67814ea.
|
We can merge cds8 PRs now. If this can also be merged, @sjvans please remove the do not merge label. Thx! |
sjvans
commented
Jun 19, 2024
sjvans
commented
Jun 19, 2024
Co-authored-by: René Jeglinsky <[email protected]>
|
@renejeglinsky i'll remove "do not merge" label once we've decided to make public |
|
@danjoa @johannes-vogel as our new protocol adapters pass the error into next (and we'll remove the old odata adapter in cds^9), i believe we could merge this one for the major... what do you think? |
sjvans
changed the title
|
@johannes-vogel could you give a review? |
|
@danjoa @johannes-vogel Ready for review |
sjvans
changed the title
renejeglinsky
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #952 + adds more info
pr re
cds.middlewares.before: #1094