Fix: Not able to consistently (or globally) overwrite vendor and product #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please update the ORD configuration documentation as well otherwise it looks good |
swennemers
reviewed
Apr 3, 2025
| ], | ||
| "packages": [ | ||
| { | ||
| "vendor": "sap:vendor:SAP:" |
There was a problem hiding this comment.
please add a statement, that the overwrites have an effect on products not being generated and packages to reference this product.
swennemers
reviewed
Apr 3, 2025
| @@ -94,8 +94,14 @@ const _getPolicyLevel = (appConfig) => | |||
| const _getDescription = (appConfig) => | |||
| appConfig.env?.description || defaults.description; | |||
|
|
|||
| const _getProducts = (appConfig) => | |||
| appConfig.env?.products || defaults.products(appConfig.packageName); | |||
| const _getProducts = (appConfig) => { | |||
There was a problem hiding this comment.
I think, we miss that we don't expose the product anymore, if the overwrite happened?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.