Skip to content

Issue-132:Error on upload #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Issue-132:Error on upload #150

wants to merge 4 commits into from

Conversation

rashmiangadi11
Copy link
Contributor

@rashmiangadi11 rashmiangadi11 commented Jul 4, 2025

one of the customer set odata-containment to 'true' in package.json "cds": {
"odata": {
"containment": true
}
It seems like req.data.ID is always empty using odata-containment. We need to use req.params[0].ID
which works for both containment true and false.
odata-containment will be made default true in futher cds releases for preventing DoS attacks.

Describe your changes

Replaced req.data.ID with req.params[0].ID

Any documentation

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have tested the functionality on my cloud environment.
  • I have provided sufficient automated/ unit tests for the code.
  • I have increased or maintained the test coverage.
  • I have ran integration tests on my cloud environment.
  • I have validated blackduck portal for any vulnerability after my commit.

Upload Screenshots/lists of the scenarios tested

  • I have Uploaded Screenshots or added lists of the scenarios tested in description

one of the customer set  odata-containment to 'true' in package.json
"cds": {
"odata": {
"containment": true
}
It seems like req.data.ID is always empty using odata-containment.
We need to use req.params[0].ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant