refactor(file-picker): default value for skipTranscoding is now `tr…

…ue` (#152)
capawesome-team · Feb 28, 2024 · 3b50f3f · 3b50f3f
1 parent f102470
commit 3b50f3f
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/.changeset/stupid-clouds-search.md b/.changeset/stupid-clouds-search.md
@@ -0,0 +1,5 @@
+---
+'@capawesome/capacitor-file-picker': major
+---
+
+refactor(ios): default value for `skipTranscoding` is now `true`
diff --git a/packages/file-picker/BREAKING.md b/packages/file-picker/BREAKING.md
@@ -17,6 +17,10 @@ The `multiple` property has been replaced by a new `limit` property in the `Pick
 
 The `File` interface has been replaced by the `PickedFile` interface.
 
+### `skipTranscoding` property
+
+The default value of the `skipTranscoding` property has been changed to `true`.
+
 ## Version 5.x.x
 
 ### Capacitor 5

diff --git a/packages/file-picker/ios/Plugin/FilePickerPlugin.swift b/packages/file-picker/ios/Plugin/FilePickerPlugin.swift
@@ -64,7 +64,7 @@ public class FilePickerPlugin: CAPPlugin {
         savedCall = call
 
         let limit = call.getInt("limit", 0)
-        let skipTranscoding = call.getBool("skipTranscoding", false)
+        let skipTranscoding = call.getBool("skipTranscoding", true)
         let ordered = call.getBool("ordered", false)
 
         implementation?.openImagePicker(limit: limit, skipTranscoding: skipTranscoding, ordered: ordered)
@@ -74,7 +74,7 @@ public class FilePickerPlugin: CAPPlugin {
         savedCall = call
 
         let limit = call.getInt("limit", 0)
-        let skipTranscoding = call.getBool("skipTranscoding", false)
+        let skipTranscoding = call.getBool("skipTranscoding", true)
         let ordered = call.getBool("ordered", false)
 
         implementation?.openMediaPicker(limit: limit, skipTranscoding: skipTranscoding, ordered: ordered)
@@ -84,7 +84,7 @@ public class FilePickerPlugin: CAPPlugin {
         savedCall = call
 
         let limit = call.getInt("limit", 0)
-        let skipTranscoding = call.getBool("skipTranscoding", false)
+        let skipTranscoding = call.getBool("skipTranscoding", true)
         let ordered = call.getBool("ordered", false)
 
         implementation?.openVideoPicker(limit: limit, skipTranscoding: skipTranscoding, ordered: ordered)

diff --git a/packages/file-picker/src/definitions.ts b/packages/file-picker/src/definitions.ts
@@ -203,7 +203,7 @@ export interface PickMediaOptions {
    *
    * Only available on iOS.
    *
-   * @default false
+   * @default true
    * @see https://developer.apple.com/documentation/photokit/phpickerconfiguration/assetrepresentationmode/current
    */
   skipTranscoding?: boolean;