feat(cloudinary): make bytes available on iOS (#89)

capawesome-team · Feb 27, 2024 · de6bcf8 · de6bcf8
1 parent 965e912
commit de6bcf8
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/.changeset/blue-rocks-ring.md b/.changeset/blue-rocks-ring.md
@@ -0,0 +1,5 @@
+---
+'@capawesome/capacitor-cloudinary': minor
+---
+
+feat(ios): make `bytes` available
diff --git a/packages/cloudinary/README.md b/packages/cloudinary/README.md
@@ -171,7 +171,7 @@ further processing after downloading.
 | Prop                   | Type                                                  | Description                                                                              | Since |
 | ---------------------- | ----------------------------------------------------- | ---------------------------------------------------------------------------------------- | ----- |
 | **`assetId`**          | <code>string</code>                                   | The unique asset identifier of the uploaded resource. Only available on Android and Web. | 0.0.1 |
-| **`bytes`**            | <code>number</code>                                   | The number of bytes of the uploaded resource. Only available on Android and Web.         | 0.0.1 |
+| **`bytes`**            | <code>number</code>                                   | The number of bytes of the uploaded resource.                                            | 0.0.1 |
 | **`createdAt`**        | <code>string</code>                                   | The timestamp at which the resource was uploaded.                                        | 0.0.1 |
 | **`duration`**         | <code>number</code>                                   | The duration of the uploaded resource in seconds.                                        | 0.1.5 |
 | **`format`**           | <code>string</code>                                   | The format of the uploaded resource.                                                     | 0.0.1 |

diff --git a/packages/cloudinary/docs/utils/README.md b/packages/cloudinary/docs/utils/README.md
@@ -61,7 +61,7 @@ Download a file from Cloudinary as a blob.
 | Prop                   | Type                                                  | Description                                                                              | Since |
 | ---------------------- | ----------------------------------------------------- | ---------------------------------------------------------------------------------------- | ----- |
 | **`assetId`**          | <code>string</code>                                   | The unique asset identifier of the uploaded resource. Only available on Android and Web. | 0.0.1 |
-| **`bytes`**            | <code>number</code>                                   | The number of bytes of the uploaded resource. Only available on Android and Web.         | 0.0.1 |
+| **`bytes`**            | <code>number</code>                                   | The number of bytes of the uploaded resource.                                            | 0.0.1 |
 | **`createdAt`**        | <code>string</code>                                   | The timestamp at which the resource was uploaded.                                        | 0.0.1 |
 | **`duration`**         | <code>number</code>                                   | The duration of the uploaded resource in seconds.                                        | 0.1.5 |
 | **`format`**           | <code>string</code>                                   | The format of the uploaded resource.                                                     | 0.0.1 |

diff --git a/packages/cloudinary/ios/Plugin/CloudinaryHelper.swift b/packages/cloudinary/ios/Plugin/CloudinaryHelper.swift
@@ -6,6 +6,7 @@ public class CloudinaryHelper {
 
     public static func createUploadResourceResult(_ resultData: CLDUploadResult) -> JSObject {
         var result = JSObject()
+        result["bytes"] = resultData.length
         result["createdAt"] = resultData.createdAt
         result["duration"] = resultData.duration
         result["format"] = resultData.format

diff --git a/packages/cloudinary/src/definitions.ts b/packages/cloudinary/src/definitions.ts
@@ -100,11 +100,9 @@ export interface UploadResourceResult {
   /**
    * The number of bytes of the uploaded resource.
    *
-   * Only available on Android and Web.
-   *
    * @since 0.0.1
    */
-  bytes?: number;
+  bytes: number;
   /**
    * The timestamp at which the resource was uploaded.
    *