Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(file-picker): pickFiles (...) doesn't work first time on Safari #111

Merged
merged 5 commits into from
Dec 30, 2023
Merged

fix(file-picker): pickFiles (...) doesn't work first time on Safari #111

merged 5 commits into from
Dec 30, 2023

Conversation

stephan-fischer
Copy link
Contributor

@stephan-fischer stephan-fischer commented Dec 29, 2023 •
edited by robingenz
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

Close #14

@robingenz robingenz changed the title bug(file-picker): pickFiles on Safari web does not bring up file pick… fix(file-picker): pickFiles (...) doesn't work first time on Safari Dec 29, 2023
robingenz
robingenz requested changes Dec 29, 2023
View reviewed changes
.changeset/funny-taxis-tie.md Outdated Show resolved Hide resolved
.changeset/funny-taxis-tie.md Outdated Show resolved Hide resolved
packages/file-picker/src/index.ts Outdated Show resolved Hide resolved
packages/file-picker/src/index.ts Show resolved Hide resolved
stephan-fischer
stephan-fischer commented Dec 30, 2023
View reviewed changes
Copy link
Contributor Author

@stephan-fischer stephan-fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 😊

stephan-fischer
stephan-fischer commented Dec 30, 2023
View reviewed changes
Copy link
Contributor Author

@stephan-fischer stephan-fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@stephan-fischer
Copy link
Contributor Author

@robingenz could you test this code, or is it possible to test the code previously via github package etc? I think we are only one step closer - i dont know if it works on compiled ts code.

@robingenz
Copy link
Member

@stephan-fischer Sure, i just published a dev version:

npm i @capawesome/[email protected]

@robingenz
Copy link
Member

Before: https://capacitor-plugin-demo-8imy2i1j7-robingenz.vercel.app/
After: https://capacitor-plugin-demo-rcpboxsdr-robingenz.vercel.app/

@stephan-fischer
Copy link
Contributor Author

@stephan-fischer Sure, i just published a dev version:

npm i @capawesome/[email protected]

Thank you, it works 🤩

@robingenz robingenz merged commit 154fb47 into capawesome-team:main Dec 30, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Dec 30, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robingenz robingenz robingenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(file-picker): pickFiles (...) doesn't work first time on Safari
2 participants
@stephan-fischer @robingenz