#131 PackageManager.getPackageInfo(packageName, 0) is deprecated as of… #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eprecated as of API 33: Android 13.0 (Tiramisu). capawesome-team#131
co-dax
changed the title
21 tasks
robingenz
requested changes
Feb 3, 2024
| @@ -227,7 +229,13 @@ private boolean isGooglePlayServicesAvailable() { | |||
|
|
|||
| private PackageInfo getPackageInfo() throws PackageManager.NameNotFoundException { | |||
| String packageName = this.getContext().getPackageName(); | |||
| return this.getContext().getPackageManager().getPackageInfo(packageName, 0); | |||
|
|
|||
| // PackageManager.getPackageInfo(packageName, 0) is deprecated as of API 33: Android 13.0 (Tiramisu). | |||
There was a problem hiding this comment.
Please remove the comment. The code should be enough.
| @@ -227,7 +229,13 @@ private boolean isGooglePlayServicesAvailable() { | |||
|
|
|||
| private PackageInfo getPackageInfo() throws PackageManager.NameNotFoundException { | |||
| String packageName = this.getContext().getPackageName(); | |||
| return this.getContext().getPackageManager().getPackageInfo(packageName, 0); | |||
|
|
|||
|
Done.
…On Sat, Feb 3, 2024 at 9:34 PM Robin Genz ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thank you for your contribution.
------------------------------
In
packages/app-update/android/src/main/java/io/capawesome/capacitorjs/plugins/appupdate/AppUpdatePlugin.java
<#134 (comment)>
:
> @@ -227,7 +229,13 @@ private boolean isGooglePlayServicesAvailable() {
private PackageInfo getPackageInfo() throws PackageManager.NameNotFoundException {
String packageName = this.getContext().getPackageName();
- return this.getContext().getPackageManager().getPackageInfo(packageName, 0);
+
+ // PackageManager.getPackageInfo(packageName, 0) is deprecated as of API 33: Android 13.0 (Tiramisu).
Please remove the comment. The code should be enough.
------------------------------
In
packages/app-update/android/src/main/java/io/capawesome/capacitorjs/plugins/appupdate/AppUpdatePlugin.java
<#134 (comment)>
:
> @@ -227,7 +229,13 @@ private boolean isGooglePlayServicesAvailable() {
private PackageInfo getPackageInfo() throws PackageManager.NameNotFoundException {
String packageName = this.getContext().getPackageName();
- return this.getContext().getPackageManager().getPackageInfo(packageName, 0);
+
Please remove the empty line.
—
Reply to this email directly, view it on GitHub
<#134 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZ6CNHAZYY3UWSYW6FECC3YR2NO5AVCNFSM6AAAAABCYIBPTSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNRRGEZDCMBYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Next time, please update the existing PR and do not create a new one. I close this for #135. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… API 33: Android 13.0 (Tiramisu).
Close #131
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset).