Skip to content

Conversation

@MattSchur
Copy link
Contributor

No description provided.

@MattSchur MattSchur requested a review from smahati as a code owner October 29, 2025 16:49
@MattSchur MattSchur requested a review from beckermarc October 29, 2025 16:49
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting Errors

  • java/fiori-drafts.md:63:1 container type should be specified [Context: "::: Aggregation Queries"]

When setting `cds.drafts.persistence` to `split` only queries that are specified by the SAP Fiori draft orchestration are supported.
:::

::: Aggregation Queries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
::: Aggregation Queries
::: info Aggregation Queries

You have to specify a container type. Possible values: info, tip, warning, danger, details, code-group, raw.

When setting `cds.drafts.persistence` to `split` only queries that are specified by the SAP Fiori draft orchestration are supported.
:::

::: warning Aggregation Queries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two thoughts:

  • two warnings next to each other? Can we avoid that?
  • It feels like this warning could be a subsection with its own L3 header. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me

@renejeglinsky renejeglinsky added the AI Review AI generated suggestions label Nov 4, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a collaborative code review enhanced by AI assistance. These suggestions offer potential improvements and insights to consider, though they're recommendations rather than requirements. You have full creative control over your code—AI simply provides additional perspective to support your decision-making process. Use whatever feels valuable and aligns with your project goals.
Model: claude-sonnet-4-20250514 | Prompt Tokens: 941 | Completion Tokens: 163

@renejeglinsky renejeglinsky removed the AI Review AI generated suggestions label Nov 4, 2025
@smahati
Copy link
Contributor

smahati commented Nov 6, 2025

@MattSchur @renejeglinsky I haven't merged it so that you can have a chance to review my edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants