-
Notifications
You must be signed in to change notification settings - Fork 139
Java: Draft Aggregations #2181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Java: Draft Aggregations #2181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting Errors
- java/fiori-drafts.md:63:1 container type should be specified [Context: "::: Aggregation Queries"]
java/fiori-drafts.md
Outdated
| When setting `cds.drafts.persistence` to `split` only queries that are specified by the SAP Fiori draft orchestration are supported. | ||
| ::: | ||
|
|
||
| ::: Aggregation Queries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ::: Aggregation Queries | |
| ::: info Aggregation Queries |
You have to specify a container type. Possible values: info, tip, warning, danger, details, code-group, raw.
java/fiori-drafts.md
Outdated
| When setting `cds.drafts.persistence` to `split` only queries that are specified by the SAP Fiori draft orchestration are supported. | ||
| ::: | ||
|
|
||
| ::: warning Aggregation Queries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two thoughts:
- two warnings next to each other? Can we avoid that?
- It feels like this warning could be a subsection with its own L3 header. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine by me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a collaborative code review enhanced by AI assistance. These suggestions offer potential improvements and insights to consider, though they're recommendations rather than requirements. You have full creative control over your code—AI simply provides additional perspective to support your decision-making process. Use whatever feels valuable and aligns with your project goals.
Model: claude-sonnet-4-20250514 | Prompt Tokens: 941 | Completion Tokens: 163
Co-authored-by: René Jeglinsky <[email protected]>
|
@MattSchur @renejeglinsky I haven't merged it so that you can have a chance to review my edit. |
No description provided.