cmake: Fix building capstone as sub-project #2629
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capstone can be built as sub-project through cmake's fetch_content mechanism. In this case, `CMAKE_SOURCE_DIR` refers to the parent project (that has nothing to do with capstone), while `PROJECT_SOURCE_DIR` refers to the root of the capstone source tree. Recently introduced changes to enable CPack (capstone-engine#2590) are using the wrong variable and are hence breaking builds that use capstone through fetch_content. Use the correct variable to fix this issue.
Do not include cpack in builds where capstone is used through fetch_content.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
capstone can be built as sub-project through cmake's fetch_content
mechanism. In this case,
CMAKE_SOURCE_DIRrefers to the parent project(that has nothing to do with capstone), while
PROJECT_SOURCE_DIRrefersto the root of the capstone source tree.
Recently introduced changes to enable CPack (#2590) are using the wrong
variable and are hence breaking builds that use capstone through
fetch_content. Use the correct variable to fix this issue.
Additionally, harden the setup even further by only including cpack whenever capstone is a top-level project. In theory, either commit is sufficient, but it seems more correct to do both things. (For reference, a look at the fmt library, which is often used through fetch_content, does something similar at https://github.com/fmtlib/fmt/blob/0c9fce2ffefecfdce794e1859584e25877b7b592/CMakeLists.txt#L503).
(Regression from 6.0.0-alpha2, where using capstone with fetch_content still worked.)