Improve Fee UX: Bidirectional Fee/Rate Input & Better Rebalance Button by Legend101Zz · Pull Request #447 · caravan-bitcoin/caravan

Legend101Zz · 2026-01-13T15:25:26Z

Problem

Users reported two major UX issues when building transactions:

No way to specify exact fee amounts: Users could only set a fee rate and had to use trial-and-error, repeatedly adjusting the rate (4 → 5 → 4.5 → 4.6 sats/vB) until they achieved the desired total fee. This was frustrating when trying to pay exactly X satoshis in fees.
Unintuitive rebalance button: The output amount rebalance feature used a small gray +/- icon button that users found difficult to discover and unclear in its purpose.
Auto-spend mode limitations: In wallet auto-spend mode, the fee amount field was completely hidden, preventing any fee customization beyond the rate.

Changes Made

Testing

Manual Testing Checklist:

Test Transactions:

Script Explorer (manual mode)
Wallet spend (auto-spend mode)
Multi-output transactions
Transactions requiring change

Related Issues

Fixes #443

changeset-bot · 2026-01-13T15:25:33Z

🦋 Changeset detected

Latest commit: a62473c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
caravan-coordinator	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-01-13T15:25:34Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
caravan-coordinator	Ready	Preview, Comment	Apr 27, 2026 6:27pm

Legend101Zz · 2026-01-13T15:53:28Z

@bucko13 let me know if we want to make the fees field editable in auto mode too , not a big change , just wanted to confirm once :)

bucko13

a couple of console.logs to cleanup. will validate functionality as well.

bucko13 · 2026-01-21T22:39:22Z

The UX still feels a little funny to me and I wonder if maybe there are some regressions. First, to be clear, this is just in the manual mode right?

Second, there's some weird state management thing going on. When i clicked back and forth on the manual toggle. I got stuck with this error that inputs must be positive. Toggling the input on and off fixed that.

Lastly the "rebalance" is missing now for the change. Note in the second screenshot below when I add a second output for change the grey + shows up, but I don't see that in the new version for some reason.

Last thought: I wonder if fees should be in sats. The fee rate is of course in sats and I feel like thinking in sats for fees is a little more intuitive. It's certainly easier to type in with the number field.

Legend101Zz · 2026-03-17T17:34:31Z

@bucko13 sorry for the huge delay on this , finally I have fixed all the issues and also I decided not have the fees edit field on auto mode as it was getting far to complicated and logic was being fragile and inaccurate to calculate the fees before hand without knowing the inputs , can you check the UI , I am happy to iterate as we are taking time so any new fresh and better UX would be very nice

Legend101Zz · 2026-03-17T17:42:05Z

@bucko13 @tomunchained how do these look ?

bucko13 · 2026-03-17T19:40:54Z

Ugh, bummer. Still having e2e failures! https://github.com/caravan-bitcoin/caravan/actions/runs/23207942129/job/67448546087?pr=447

bucko13 · 2026-03-17T21:31:32Z

Ah, i think this is a legitimate e2e failure!

    1 failed
      [mutate-wallet] › e2e/tests/mutate/transaction-flow.spec.ts:84:3 › Transaction Creation and Signing › manual coin selection: create, sign, broadcast

bucko13 · 2026-03-17T21:34:56Z

-    )
-      rate = "0";
-    setFeeRate(rate);
+    setFeeRate(rate === "" ? "0" : rate); // Reducer handles fee calculation and validation


Can also do:

Math.round(num * 100) / 100

bucko13

couple small questions/comments. Need to fix e2e as well. I'll test functionally next but the screenshots look good

bucko13 · 2026-03-17T21:40:17Z

+  let feeRateString = action.value;
+
+  // Limit to 2 decimal places
+  if (feeRateString && feeRateString.includes(".")) {


Same

Math.round((num + Number.EPSILON) * 100) / 100

(or similar)

bucko13 · 2026-03-17T21:54:11Z

UX Feedback:

I don't love that the up arrow increments by a hundredth of a sat/vbyte when doing the up arrow. that's a very small unit of change that I don't think has much value

It looks like the fee rate is not updating with the fee amount

Got some weird UI juping around when I added a change. There was a

And this was funky too. When i changed the fee amount, rebalance was only available on the recipient output, rather than the change one which is where I would expect it

Legend101Zz · 2026-03-21T14:22:53Z

Ah, i think this is a legitimate e2e failure!

    1 failed
      [mutate-wallet] › e2e/tests/mutate/transaction-flow.spec.ts:84:3 › Transaction Creation and Signing › manual coin selection: create, sign, broadcast

I yes I suspected that as I made changes to the transcation creation flow so would need to make changes to selectors in the Page model in. e2e , glad it's working fine :)

github-actions · 2026-04-21T04:33:12Z

This pull request has been inactive for 30 days and has been marked as stale. It will be closed in 7 days if no further activity occurs. To keep this PR open, add the "long-lived" label or comment on it.

Address Buck's review feedback: only show the Rebalance button on the change output (or on recipients when no change output is set), and use Math.round((n + Number.EPSILON) * 100) / 100 for fee-rate rounding so floating-point artifacts don't leak into the input.

Buck noted ↑/↓ on the fee rate input bumping by 0.01 sat/vB has no practical value. Switch the step to 1 (manual decimal entry still works, reducer still rounds to 2 places). Also fix the row jumping when a change output is added: the rebalance column (xs=2) plus delete column (xs=1) was overflowing past 12, causing the row to wrap. Address column shrunk to xs=6 and both action slots are now always rendered (empty when inactive) so columns stay stable. Helper text under the Rebalance button is clipped with an ellipsis instead of wrapping to a second line.

Buck reported the fee rate field staying stale while editing the fee amount. updateFee was guarded by !feeError, so any non-fatal validation hiccup (intermediate typing, fee-too-high) suppressed the back-calc and left the rate showing the previous value. Drop the !feeError guard. As long as inputs are known and feeSats > 0, recompute the rate from the typed fee. Use the same EPSILON-based rounding as updateFeeRate so display values stay consistent.

The IconButton wrapping AddCircle was replaced by a labelled Button, so locating it via the auto-generated AddCircleIcon test id is brittle and only matches the "Increase" variant. Tag the button with data-testid="rebalance-button" and have the manual-coin-selection flow look it up directly.

…c runs bitcoinsToSatoshis returns a string, not a BigNumber. updateFee was storing that string in feeSats and then guarding the back-calculation with BigNumber.isBigNumber(feeSats), which always returned false. The fee field updated, but feeRate silently stayed at its previous value — the symptom Buck and the maintainer both saw in the form and Preview modal. Wrap the result in new BigNumber(...) so the guards behave like numbers and the back-calc actually fires. Add a regression test that mirrors the reported scenario (1 input of 6.25 BTC, two outputs, fee=0.001 BTC) and asserts the rate climbs well above the previous value of 1 sat/vB.

…nge-in-tx # Conflicts: # apps/coordinator/e2e/tests/03-transaction_flow.spec.ts

Legend101Zz · 2026-04-27T18:20:38Z

UX Feedback:

I don't love that the up arrow increments by a hundredth of a sat/vbyte when doing the up arrow. that's a very small unit of change that I don't think has much value
It looks like the fee rate is not updating with the fee amount

Got some weird UI juping around when I added a change. There was a
And this was funky too. When i changed the fee amount, rebalance was only available on the recipient output, rather than the change one which is where I would expect it

Thank you for all the testing ... I have resolved all these bugs and flaky behaviour on my end , can you please test it out again :)

feat: add rebalance button for better UX

f10e416

vercel Bot deployed to Preview January 13, 2026 15:27 View deployment

Legend101Zz requested a review from bucko13 January 13, 2026 15:53

Merge branch 'main' into feat/fees-based-change-in-tx

c392346

vercel Bot deployed to Preview January 21, 2026 14:48 View deployment

bucko13 reviewed Jan 21, 2026

View reviewed changes

Comment thread apps/coordinator/src/components/ScriptExplorer/OutputsForm.jsx Outdated

bucko13 requested changes Jan 21, 2026

View reviewed changes

Comment thread apps/coordinator/src/components/ScriptExplorer/OutputsForm.jsx Outdated

Merge branch 'main' into feat/fees-based-change-in-tx

6b1663a

vercel Bot deployed to Preview February 10, 2026 21:53 View deployment

Merge branch 'main' into feat/fees-based-change-in-tx

25577ac

vercel Bot deployed to Preview February 24, 2026 15:25 View deployment

fix: sync issues and styling for fees and feeRate

9deae58

vercel Bot deployed to Preview March 12, 2026 02:39 View deployment

fix: bump fees button and some UI changes

7dbe572

vercel Bot deployed to Preview March 17, 2026 17:31 View deployment

chore: add changeset

9f3b381

vercel Bot deployed to Preview March 17, 2026 17:38 View deployment

bucko13 added the final review label Mar 17, 2026

bucko13 reviewed Mar 17, 2026

View reviewed changes

bucko13 requested changes Mar 17, 2026

View reviewed changes

github-actions Bot added the stale label Apr 21, 2026

Legend101Zz added 4 commits April 27, 2026 20:47

vercel Bot deployed to Preview April 27, 2026 18:06 View deployment

Legend101Zz added 2 commits April 27, 2026 23:45

Merge remote-tracking branch 'upstream/main' into feat/fees-based-cha…

c2a983a

…nge-in-tx # Conflicts: # apps/coordinator/e2e/tests/03-transaction_flow.spec.ts

Legend101Zz force-pushed the feat/fees-based-change-in-tx branch from bf1b0f3 to c2a983a Compare April 27, 2026 18:19

vercel Bot deployed to Preview April 27, 2026 18:22 View deployment

Legend101Zz requested a review from bucko13 April 27, 2026 18:24

style: apply prettier formatting to fix CI lint

a62473c

vercel Bot deployed to Preview April 27, 2026 18:27 View deployment

github-actions Bot removed the stale label Apr 28, 2026

Conversation

Legend101Zz commented Jan 13, 2026

Problem

Changes Made

Testing

Related Issues

Uh oh!

changeset-bot Bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel Bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Legend101Zz commented Jan 13, 2026

Uh oh!

Uh oh!

bucko13 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bucko13 commented Jan 21, 2026

Uh oh!

Legend101Zz commented Mar 17, 2026

Uh oh!

Legend101Zz commented Mar 17, 2026

Uh oh!

bucko13 commented Mar 17, 2026

Uh oh!

bucko13 commented Mar 17, 2026

Uh oh!

bucko13 Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

bucko13 left a comment

Choose a reason for hiding this comment

Uh oh!

bucko13 Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

bucko13 commented Mar 17, 2026

Uh oh!

Legend101Zz commented Mar 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

Legend101Zz commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Jan 13, 2026 •

edited

Loading

vercel Bot commented Jan 13, 2026 •

edited

Loading