feat: implement Coldcard address verification#494
Open
harrshita123 wants to merge 3 commits intocaravan-bitcoin:mainfrom
Open
feat: implement Coldcard address verification#494harrshita123 wants to merge 3 commits intocaravan-bitcoin:mainfrom
harrshita123 wants to merge 3 commits intocaravan-bitcoin:mainfrom
Conversation
🦋 Changeset detectedLatest commit: e00cb7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Heads up, needs a changeset |
Contributor
|
I'm also not seeing it here by the way. 
|
Contributor
|
This pull request has been inactive for 30 days and has been marked as stale. It will be closed in 7 days if no further activity occurs. To keep this PR open, add the "long-lived" label or comment on it. |
Author
|
Fixed the CI issues. I've updated the PR ,please take another look when you get a chance. |
# Conflicts: # apps/coordinator/src/components/Slices/ConfirmAddress.jsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
Issue Number:
Fixes #476
Snapshots/Videos:
If relevant, did you update the documentation?
N/A
Summary
This PR adds support for on-device address verification for Coldcard wallets.
Because Coldcard is an air-gapped device, it cannot be queried directly over USB like a Trezor or Ledger. To solve this, I've implemented a "Guided Manual Verification" flow:
manualverification flag.Does this PR introduce a breaking change?
No
Checklist
npm run changeset)Other information
The verification flow is designed to be extensible; by using the
manualflag in the interaction's run() response, the coordinator can support other air-gapped devices using the same architectural pattern.Have you read the contributing guide?
Yes
For information on creating and using changesets, please refer to our documentation on changesets.