Implement Fingerprint Extraction from BIP380 descriptors#24
Closed
cc-unchained wants to merge 1 commit intocaravan-bitcoin:mainfrom
Closed
Implement Fingerprint Extraction from BIP380 descriptors#24cc-unchained wants to merge 1 commit intocaravan-bitcoin:mainfrom
cc-unchained wants to merge 1 commit intocaravan-bitcoin:mainfrom
Conversation
🦋 Changeset detectedLatest commit: d69b9ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e609739 to
9af2ab3
Compare
9af2ab3 to
d69b9ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement fingerprint extraction from BIP380 descriptors
This change adds a new function
getFingerprintFromBip380Descriptorto extract the master key fingerprint from BIP380 descriptor strings. The function parses the key origin information (enclosed in square brackets) and returns the fingerprint as a lowercase hex string.Key Changes
New function:
getFingerprintFromBip380Descriptor(descriptor: string): string | nullUses regex pattern to match [fingerprint]/ format
Returns fingerprint in lowercase hex or null if not found
Handles both uppercase and lowercase input
Comprehensive tests covering:
wpkh descriptors with key origin
sh(wpkh) descriptors with key origin
Descriptors without key origin (returns null)
Invalid descriptors (returns null)
Case normalization to lowercase
Usage
This enhancement improves compatibility with BIP380 standards and provides
convenient access to fingerprint information for wallet management and key
identification.