Skip to content

fix(tabs): address a11y issues #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(tabs): address a11y issues #2200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/Tabs/Tab.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@
<!-- svelte-ignore a11y-mouse-events-have-key-events -->
<li
tabindex="-1"
role="presentation"
role="tab"
aria-selected={selected}
aria-disabled={disabled}
class:bx--tabs__nav-item={true}
class:bx--tabs__nav-item--disabled={disabled}
class:bx--tabs__nav-item--selected={selected}
Expand Down Expand Up @@ -60,10 +62,7 @@
>
<a
bind:this={ref}
role="tab"
tabindex={disabled ? "-1" : tabindex}
aria-selected={selected}
aria-disabled={disabled}
{id}
{href}
class:bx--tabs__nav-link={true}
Expand Down
22 changes: 15 additions & 7 deletions tests/Tabs/Tabs.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,12 @@ describe("Tab", () => {

const tab = screen.getByRole("tab", { name: "Test Tab" });
expect(tab).toBeInTheDocument();
expect(tab).toHaveAttribute("href", "#test");
expect(tab).toHaveAttribute("tabindex", "0");
expect(tab).toHaveAttribute("id", "test-tab");
expect(tab).toHaveAttribute("aria-selected", "true");

const link = tab.querySelector("a");
expect(link).toHaveAttribute("href", "#test");
expect(link).toHaveAttribute("tabindex", "0");
expect(link).toHaveAttribute("id", "test-tab");
});

it("should render with custom label", () => {
Expand All @@ -153,29 +156,34 @@ describe("Tab", () => {
render(Tab, { props: { href: "/custom" } });

const tab = screen.getByRole("tab");
expect(tab).toHaveAttribute("href", "/custom");
const link = tab.querySelector("a");
expect(link).toHaveAttribute("href", "/custom");
});

it("should handle disabled state", () => {
render(Tab, { props: { disabled: true } });

const tab = screen.getByRole("tab");
expect(tab).toHaveAttribute("aria-disabled", "true");
expect(tab).toHaveAttribute("tabindex", "-1");

const link = tab.querySelector("a");
expect(link).toHaveAttribute("tabindex", "-1");
});

it("should handle custom tabindex", () => {
render(Tab, { props: { tabindex: "1" } });

const tab = screen.getByRole("tab");
expect(tab).toHaveAttribute("tabindex", "1");
const link = tab.querySelector("a");
expect(link).toHaveAttribute("tabindex", "1");
});

it("should handle custom id", () => {
render(Tab, { props: { id: "custom-id" } });

const tab = screen.getByRole("tab");
expect(tab).toHaveAttribute("id", "custom-id");
const link = tab.querySelector("a");
expect(link).toHaveAttribute("id", "custom-id");
});

it("should be clickable when enabled", async () => {
Expand Down