Skip to content

Stops propagation of clicks when combined with data table header. #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stops propagation of clicks when combined with data table header. #464

wants to merge 1 commit into from

Conversation

@garkey
Copy link

@garkey garkey commented Dec 17, 2020 •
edited
Loading

When clicking on the Dropdown target button of so, and sortable=true, it seems not possible to prevent the sort function from being triggered by other means.

<span slot="cell-header" let:header>
  <Dropdown />
</span>

@garkey garkey requested a review from josefaidt as a code owner December 17, 2020 06:27
@vercel
Copy link

vercel bot commented Dec 17, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-svelte/carbon-components-svelte/21a8hgjfj
✅ Preview: https://carbon-components-svelte-git-dropdown-click-stoppropagation.carbon-svelte.vercel.app

@garkey garkey changed the title Stops propagation of clicks when combined with data table header, whi… Stops propagation of clicks when combined with data table header. Dec 17, 2020
@metonym metonym force-pushed the master branch 2 times, most recently from e7485c4 to 417102d Compare November 8, 2023 03:27
@metonym metonym force-pushed the master branch 3 times, most recently from 234c1f9 to e774974 Compare October 28, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josefaidt josefaidt Awaiting requested review from josefaidt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@garkey