Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new category in sidebar for compliance links #18550

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Feb 10, 2025

Closes #16053

Added style About category to support the compliance links.

Unfortunately, Storybook doesn’t provide a clean way to add links in the sidebar, so we’re using a “hack” to make it work. Here’s the source used in this PR.

Changelog

New

  • About category in storybook sidebar

Testing / Reviewing

  • Storybook should work as expected
  • Privacy link should open a new window
  • Cookie Preferences should open a modal

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 0e07af8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67aa221e4cc5860008fcc6e7
😎 Deploy Preview https://deploy-preview-18550--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0e07af8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67aa221ee9a16600085a6e57
😎 Deploy Preview https://deploy-preview-18550--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0e07af8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67aa221e7adb5c0008ac9dbe
😎 Deploy Preview https://deploy-preview-18550--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 454d77b
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67aa223a6d5f5000084a2b87
😎 Deploy Preview https://deploy-preview-18550--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 454d77b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67aa2239ce00bd0008c0309a
😎 Deploy Preview https://deploy-preview-18550--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.04%. Comparing base (7557e1d) to head (454d77b).
Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18550      +/-   ##
==========================================
- Coverage   84.17%   84.04%   -0.13%     
==========================================
  Files         408      408              
  Lines       14435    14470      +35     
  Branches     4690     4660      -30     
==========================================
+ Hits        12150    12162      +12     
- Misses       2121     2142      +21     
- Partials      164      166       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 454d77b
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67aa22391868b7000874aa4d
😎 Deploy Preview https://deploy-preview-18550--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook footer display issue on mobile
1 participant