fix: update Dropdown and MultiSelect to handle interactive labels #18643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16987
Updated
Dropdown
andMultiSelect
to handle interactive labels.Changelog
Changed
Dropdown
andMultiSelect
to handle interactive labels.Testing / Reviewing
yarn test packages/react/src/components/Dropdown packages/react/src/components/MultiSelect
There seem to be two solutions to this problem:
getLabelProps
conditionally based on iftitleText
is an element.label
iftitleText
is an element.I went with the second approach for two reasons:
ToggletipLabel
(or any other label element) inside of alabel
didn't seem like the most logical thing to do.I'm curious to hear others thoughts.
I tried to write a test for these changes. I couldn't get it to pass. I think it has something to do with the changing visibility of the popover and its visibility from the test's perspective. Curious to hear if anyone has suggestions to test these changes. Alternatively, I created Storybook entries.