Skip to content

Conversation

@Marco-Herrmann
Copy link
Contributor

Added class Sensor
Applied to example with rigid body --> double_pendulum.py
Applied to example with rod --> rod_export_demo.py

@JonasBreuling
Copy link
Contributor

Sieht gut aus. Ich habe es aber nicht getestet.

@lisaeb wie sieht das für dich aus? Was brauchst du zusätzlich/ was machst du anders?

@JonasBreuling
Copy link
Contributor

Please remove the *.csv files from the commit.

added *.csv files to gitignore
Copy link
Contributor

@JonasBreuling JonasBreuling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. @lisaeb what do you think?

@lisaeb
Copy link
Contributor

lisaeb commented Dec 11, 2025

Looks fine for me, as a default export for now totally sufficient. Everything beyond is solver and/or contribution specific and would require the option to add own functions that are evaluated and added, which we should consider imo in the future. Otherwise, as soon as the need for specialised output arises, say for instance a force, the workflow will become messy/hacky.

@JonasBreuling JonasBreuling marked this pull request as ready for review December 11, 2025 19:27
@JonasBreuling JonasBreuling merged commit 491e48c into cardilloproject:main Dec 17, 2025
2 checks passed
@Marco-Herrmann Marco-Herrmann deleted the csv_sensor branch December 17, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants