Fix public method name architecture test

carlosas · Feb 14, 2025 · 243d8b5 · 243d8b5
1 parent 7a10ecd
commit 243d8b5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/tests/architecture/AssertionTest.php b/tests/architecture/AssertionTest.php
@@ -2,10 +2,7 @@
 
 namespace Tests\PHPat\architecture;
 
-use PHPat\Parser\TypeNodeParser;
 use PHPat\Rule\Assertion\Assertion;
-use PHPat\Rule\Assertion\Declaration\DeclarationAssertion;
-use PHPat\Rule\Assertion\Relation\RelationAssertion;
 use PHPat\Selector\Selector;
 use PHPat\Test\Builder\Rule;
 use PHPat\Test\PHPat;
@@ -29,14 +26,6 @@ public function test_rules_are_not_abstract(): Rule
         ;
     }
 
-    public function test_rules_public_method_named(): Rule
-    {
-        return PHPat::rule()
-            ->classes(Selector::classname('/.*\\\Extractor\\\.*Extractor/', true))
-            ->shouldHaveOnlyOnePublicMethodNamed('getNodeType')
-        ;
-    }
-
     /*public function test_rules_dependencies(): Rule
     {
         return PHPat::rule()

diff --git a/tests/architecture/CleanClassesTest.php b/tests/architecture/CleanClassesTest.php
@@ -4,6 +4,7 @@
 
 use PHPat\Selector\Selector;
 use PHPat\Selector\SelectorPrimitive;
+use PHPat\Statement\Builder\StatementBuilder;
 use PHPat\Test\Builder\AbstractStep;
 use PHPat\Test\Builder\Rule;
 use PHPat\Test\PHPat;
@@ -28,4 +29,12 @@ public function test_non_abstract_classes_are_final(): Rule
             ->shouldBeFinal()
         ;
     }
+
+    public function test_builders_only_public_method_build(): Rule
+    {
+        return PHPat::rule()
+            ->classes(Selector::implements(StatementBuilder::class))
+            ->shouldHaveOnlyOnePublicMethodNamed('build')
+        ;
+    }
 }