feat: Add support for attribute arguments in AppliesAttribute #319
Conversation
|
Also update the docs please 🙂 |
raffaelecarelle
force-pushed
the
AppliesAttributeWithArgumentsRule
branch
2 times, most recently
from
84493a8 to
dc52826
Compare
|
hello @carlosas thank for the feedback. I've done the fixes. Let me know if now is ok |
|
I did a checkout in my local and run the tests manually, and I found they are failing. There is now a new phpunit folder that is not being run by the workflow. I updated the CI configuration to include it. Could you merge/rebase the current 
|
|
Also something is not ok in the coding standards on PHP 7.4. I increased the verbosity to see which rule is failing in the next run |
Modified AppliesAttribute to handle optional attribute arguments for precise matching. Updated relevant methods, fixtures, and added unit tests to ensure functionality with arguments and regex-based matching.
Tests and logic are updated to bypass attribute matching when running on PHP versions earlier than 8.0. This ensures compatibility and prevents failures related to unsupported features.
Reordered constructor parameters and renamed `attributeName` to `classname` for improved clarity and consistency. Updated all affected method calls and tests to reflect these changes. Removed redundant comments and unused code for better maintainability.
Added clarification on passing multiple arguments with values to the `Selector::appliesAttribute` method. This improves the readability and understanding of the documentation for users.
raffaelecarelle
force-pushed
the
AppliesAttributeWithArgumentsRule
branch
from
c4d8a18 to
cc0c172
Compare
Reordered arguments in the AppliesAttribute test case to match the updated constructor signature. This ensures consistency and prevents potential test failures.
|
PHP-CS-Fixer seems to want just this in AppliesAttributeTest.php : /**
* @coversNothing
*/https://cs.symfony.com/doc/rules/php_unit/php_unit_test_class_requires_covers.html |
Ensure tests are skipped for PHP versions below 8.0 using `setUp`. This prevents unsupported functionality from running and ensures consistent behavior across different environments.
raffaelecarelle
force-pushed
the
AppliesAttributeWithArgumentsRule
branch
from
27ee581 to
f3c6868
Compare
Added @Covers annotations for AppliesAttribute::getName and AppliesAttribute::matches methods to improve test coverage clarity. This ensures better tracking of what methods are being explicitly tested.
raffaelecarelle
force-pushed
the
AppliesAttributeWithArgumentsRule
branch
2 times, most recently
from
29ea06b to
b4e169e
Compare
Replaced PHPUnit attributes with a data provider in `AppliesAttributeTest`. This improves readability and centralizes
raffaelecarelle
force-pushed
the
AppliesAttributeWithArgumentsRule
branch
from
b4e169e to
b75b60a
Compare
|
@carlosas, here we go :) |
|
Good job. However I'm testing manually and found another issue. When NOT using named arguments in the Attribute application, the test fails. #[SimpleAttribute(something: 'something')]
class FixtureClass extends SimpleAbstractClass implements SimpleInterfacevs #[SimpleAttribute('something')]
class FixtureClass extends SimpleAbstractClass implements SimpleInterfaceis it because of the test or because of the feature? |
|
Since I merged the other PR, remember to merge/rebase the latest master 🙂 almost there! |
Hi @carlosas, as I said on PR description, this is a feature limitation for now |
Idea
Modify ´AppliesAttribute´ selector for search a class that applies attribute with certain argument value (if passed, otherwise the behavious is like previously PR).
Limitations
Arguments check works if attributes is defined with ´Named Parameters´