Skip to content

Exit with non-zero code when some fanouts failed #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carpalsgrabby wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Exit with non-zero code when some fanouts failed #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions choose_best_layout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,17 @@ def main() -> None:
if not app_path.is_file():
print(f"ERROR: app.py not found at {app_path}", file=sys.stderr)
sys.exit(1)

had_errors = False

for f in fanouts:
try:
data = run_app(app_path, args.leaves, args.style, f, print_cmd=args.print_cmd)
layouts.append(LayoutResult(fanout=f, data=data))
except Exception as e: # noqa: BLE001
had_errors = True
if not args.quiet_errors:
print(f"ERROR for fanout={f}: {e}", file=sys.stderr)

layouts: List[LayoutResult] = []

Expand Down Expand Up @@ -162,6 +173,8 @@ def main() -> None:
f"Best fanout for leaves={args.leaves}, style={args.style}, "
f"metric={args.metric}: {best.fanout} (marked with *)"
)
if had_errors:
sys.exit(2)


if __name__ == "__main__":
Expand Down