Skip to content

Add a sanity check for --metric existence #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carpalsgrabby wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a sanity check for --metric existence #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions choose_best_layout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,11 @@ def main() -> None:
print("No successful layouts computed. (Did app.py error out for all?)", file=sys.stderr)
sys.exit(1)

# Warn if metric does not appear in ANY layout
if all(args.metric not in lr.data for lr in layouts):
print(f"WARNING: metric '{args.metric}' was not found in any layout results.", file=sys.stderr)


# choose best by metric (minimize)
best = min(
layouts,
Expand Down