Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bal7hazar
requested changes
May 27, 2025
Collaborator
There was a problem hiding this comment.
Several issues here:
- Pin icons look compressed here instead of being squared
- The padding is kind of doubled here, not matching the target
- Game icon doesnt have the right size
Note: I didnt check elsewhere, I advise to review the whole again by yourself to ensure it matches the design better
| Implementation | Design |
|---|---|
 |
 |
Contributor
Author
|
oh i think the figma bit different i didnt notice theres 2 version for mobile pin achievement icon Updated the figma, compressed one instead of squared is the right one |
Collaborator
|
Achievement Header still looks off from target, the target is 76px height, when the impl is 106px height
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.