Skip to content

test coinbase apple pay#2289

Open
broody wants to merge 1 commit intomainfrom
test-coinbase
Open

test coinbase apple pay#2289
broody wants to merge 1 commit intomainfrom
test-coinbase

Conversation

@broody
Copy link
Contributor

@broody broody commented Dec 12, 2025

Note

Integrates a Coinbase Pay Apple Pay iframe into on-chain checkout and refactors QuantityControls to accept custom children instead of handling purchase/bridge actions.

  • On-chain Checkout UI:
    • Embed Coinbase Pay Apple Pay iframe in packages/keychain/src/components/purchasenew/checkout/onchain/index.tsx inside QuantityControls.
    • Stop rendering the purchase/bridge button; onSendDeposit reference commented out.
    • Update QuantityControls usage to pass only quantity controls and provide custom child content.
  • Component Refactor:
    • Simplify QuantityControls API by removing isLoading, bridgeFrom, onPurchase, and onBridge props; add children slot for custom actions.
    • Remove internal purchase/bridge button; retain increment/decrement controls and disabled-state logic.

Written by Cursor Bugbot for commit 1eb8386. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Dec 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
controller-example-next Ready Ready Preview Dec 12, 2025 7:50pm
keychain Ready Ready Preview Dec 12, 2025 7:50pm
keychain-storybook Ready Ready Preview Dec 12, 2025 7:50pm

onClick={bridgeFrom !== null ? onSendDeposit : handlePurchase}
>
{bridgeFrom ? "Bridge" : `Buy ${quantity}`}
</Button> */}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Purchase and bridge functionality completely disabled by comment

The main purchase/bridge Button component is commented out, leaving users unable to complete purchases or bridge operations. The test iframe replaces the actual functional button, breaking the core checkout flow. This appears to be unfinished test code that was accidentally committed before being production-ready.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant