-
Notifications
You must be signed in to change notification settings - Fork 44
feat: move asWalletStandard to controller package #2364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
f4b107f to
080bf1c
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
080bf1c to
8ed14c3
Compare
53c8358 to
826d326
Compare
826d326 to
729faf7
Compare
Move the wallet standard functionality from @cartridge/connector to @cartridge/controller so users who don't use starknet-react can access it directly. The connector now delegates to the controller's implementation. Co-Authored-By: Claude Opus 4.5 <[email protected]>
729faf7 to
7d4ceb0
Compare
The wallet standard's `standard:disconnect` only performs local cleanup (clears accounts, emits change event) without calling through to the controller. Wrap `StarknetInjectedWallet` to also call `controller.disconnect()` for proper keychain session cleanup. Co-Authored-By: Claude Opus 4.6 <[email protected]>
7d4ceb0 to
c9a1e5e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2364 +/- ##
==========================================
- Coverage 20.89% 19.81% -1.08%
==========================================
Files 307 325 +18
Lines 31079 33141 +2062
Branches 880 883 +3
==========================================
+ Hits 6493 6567 +74
- Misses 24574 26562 +1988
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
Claude finished @kronosapiens's task —— View job Documentation Update Analysis ✅I've analyzed the PR changes and updated the documentation accordingly. Todo List:
Analysis SummaryThe PR successfully moved Documentation Updates MadeUpdated
Key Changes:
Files Updated:
Note: The docs-repo directory contains a separate git repository, so the changes have been made to the files but cannot be committed through this repository. The documentation files have been updated and are ready for review. |
Updates documentation to reflect changes made in:
feat: move asWalletStandard to controller package
Related controller PR: cartridge-gg/controller#2364
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Summary
asWalletStandard()from@cartridge/connectorto@cartridge/controllerContext
Users trying to install
@cartridge/connectorwithout starknet-react were getting peer dependency errors. TheasWalletStandard()helper was the only reason some users needed the connector package, but it doesn't actually depend on starknet-react - it uses@starknet-io/get-starknet-wallet-standardwhich is independent.Usage
Test plan
🤖 Generated with Claude Code