feat: added close() to ControllerProvider#2373
Merged
rsodre merged 2 commits intocartridge-gg:mainfrom Feb 9, 2026
Merged
Conversation
|
@rsodre is attempting to deploy a commit to the cartridge Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rsodre
force-pushed
the
close-controller
branch
from
9f6652f to
561a96d
Compare
rsodre
force-pushed
the
close-controller
branch
from
561a96d to
c37e3b3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2373 +/- ##
==========================================
- Coverage 20.89% 19.81% -1.08%
==========================================
Files 307 325 +18
Lines 31079 33142 +2063
Branches 880 883 +3
==========================================
+ Hits 6493 6568 +75
- Misses 24574 26562 +1988
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rsodre
force-pushed
the
close-controller
branch
2 times, most recently
from
bf0b38f to
d47db23
Compare
rsodre
force-pushed
the
close-controller
branch
from
d47db23 to
cf2cf0d
Compare
rsodre
force-pushed
the
close-controller
branch
from
cf2cf0d to
f851dff
Compare
rsodre
force-pushed
the
close-controller
branch
from
f851dff to
408f075
Compare
MartianGreed
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.