Skip to content

Always show quantity in starterpack purchase button#2390

Merged
broody merged 1 commit intomainfrom
fix/starterpack-quantity-display
Feb 7, 2026
Merged

Always show quantity in starterpack purchase button#2390
broody merged 1 commit intomainfrom
fix/starterpack-quantity-display

Conversation

@broody
Copy link
Contributor

@broody broody commented Feb 7, 2026

Summary

  • Updates the purchase button to always display quantity, even for single items
  • Changes "Buy" to "Buy 1" for consistency

Changes

  • Modified QuantityControls component to always show quantity in button label
  • Removed conditional logic that hid quantity when it was 1

Test plan

  • Verify starterpack purchase shows "Buy 1" for single items
  • Verify multiple items still show "Buy N" correctly
  • Check all purchase flows display quantity consistently

🤖 Generated with Claude Code

Previously the buy button would show just "Buy" for single items and "Buy N" for multiple items. This made the quantity implicit for the default case.

Now it always displays "Buy {quantity}" (e.g., "Buy 1") to make the quantity explicit and consistent across all purchase flows.

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
@vercel
Copy link

vercel bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Feb 7, 2026 0:40am
keychain Ready Ready Preview Feb 7, 2026 0:40am
keychain-storybook Ready Ready Preview Feb 7, 2026 0:40am

Request Review

@broody broody merged commit bd8ff7d into main Feb 7, 2026
10 of 11 checks passed
@broody broody deleted the fix/starterpack-quantity-display branch February 7, 2026 00:42
@claude
Copy link
Contributor

claude bot commented Feb 7, 2026

Claude finished @broody's task —— View job


Analyzing Controller Repository Changes for Documentation Updates

I'll analyze the changes from PR #2390 and update documentation in the cartridge-gg/docs repository if needed.

Todo List:

  • Review the changed file to understand the functionality change
  • Explore the docs-repo directory structure
  • Assess if documentation updates are needed for the quantity display change
  • Update documentation if necessary

Analysis of Changes:

  • The PR modified the QuantityControls component to always display quantity in the purchase button
  • Changed from conditional "Buy" vs "Buy {quantity}" to always showing "Buy {quantity}"
  • This ensures consistency where single items show "Buy 1" instead of just "Buy"
  • This is a minor UI consistency improvement, not a breaking change or new feature

Documentation Assessment:
After reviewing the docs-repo structure and relevant documentation files (particularly starter-packs.md), I found that:

  1. No documentation updates are needed - The existing documentation focuses on API usage, configuration, and integration patterns rather than describing specific UI text or button labels
  2. The change is purely cosmetic - This UI consistency fix doesn't affect any documented APIs, configuration options, or user-facing functionality
  3. User-facing functionality remains unchanged - The purchase flow, methods, and behavior are identical; only the button text is more consistent

Conclusion:
The quantity display change in PR #2390 is a minor UI improvement that enhances consistency but doesn't require documentation updates. The change doesn't impact any documented APIs, configuration options, or user workflows described in the documentation.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant