fix: reset navigation stack when showing execution prompt #2391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes state issue where execution prompt incorrectly showed back button on second display instead of close button. Now uses reset: true to clear navigation history when opening execute route, ensuring consistent UX. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2391 +/- ##
==========================================
- Coverage 20.89% 19.81% -1.08%
==========================================
Files 307 325 +18
Lines 31079 33140 +2061
Branches 880 883 +3
==========================================
+ Hits 6493 6567 +74
- Misses 24574 26561 +1987
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes state issue where the execution prompt incorrectly showed a back button on the second display instead of the close button.
Changes
reset: trueto execute route navigation to clear navigation historyresetoptionTesting
All 16 tests passing ✅