feat: use accountPrivate for starterpack verification#2486
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Claude finished @broody's task —— View job Analyzing PR for documentation updates
Analysis CompleteNo documentation updates needed. This PR is an internal refactor that moves phone number verification data from the
The documentation in Per the documentation rules: "DEFAULT TO NO CHANGES. Most code PRs do not need docs updates. Internal refactors, test changes, CI changes, and dependency bumps need nothing." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move starterpack Apple Pay phone verification off
meand onto the authenticatedaccountPrivatequery.Update the starterpack verification and onchain checkout flows to use
accountPrivate.phoneNumberandaccountPrivate.phoneNumberVerifiedAtwhile keeping email checks onme.Regenerate the keychain GraphQL API types for the new query.
Validation
pnpm --filter @cartridge/keychain exec prettier --check src/components/purchasenew/checkout/onchain/index.tsx src/components/purchasenew/verification/index.tsxread_lintson the touched starterpack files