Skip to content

feat: detect swap for LS2, avnu#2493

Merged
rsodre merged 11 commits intomainfrom
swap-update
Mar 24, 2026
Merged

feat: detect swap for LS2, avnu#2493
rsodre merged 11 commits intomainfrom
swap-update

Conversation

@rsodre
Copy link
Collaborator

@rsodre rsodre commented Mar 18, 2026

  • generic swap detection (one endpoint array for each type)
  • detect avnu swap and display swap review screen
  • detect LS2 purchase game as a single swap and display swap review screen
  • removed additional tx count from Swap button
  • misc layout updates

@vercel
Copy link

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Mar 24, 2026 4:09pm
keychain Ready Ready Preview Mar 24, 2026 4:09pm
keychain-storybook Ready Ready Preview Mar 24, 2026 4:09pm

Request Review

@claude
Copy link
Contributor

claude bot commented Mar 24, 2026

Claude finished @rsodre's task —— View job


Documentation Analysis Complete

Tasks:

  • Analyze PR changes to understand user-facing impact
  • Check if documentation updates are needed per the rules
  • Determine final action

Analysis Summary

The PR #2493 adds internal support for detecting swap transactions from multiple DEX protocols (AVNU, Ekubo) and LS2 game purchases. The changes include:

  1. Generic swap detection system - Pattern-based approach supporting multiple DEX types
  2. AVNU DEX support - New ABI and detection for multi_route_swap entrypoint
  3. LS2 game purchase detection - Special handling to display as a swap transaction
  4. UI improvements - Enhanced swap review screen, layout updates

Documentation Decision: NO UPDATES NEEDED

Reasoning:

Following the provided rules (particularly "DEFAULT TO NO CHANGES"), documentation updates are not required because:

  1. Internal implementation detail: The swap detection logic is an internal feature that automatically recognizes and displays swap transactions. Users don't need to configure or interact with it differently.

  2. No API changes: There are no new public APIs, configuration options, or integration steps that developers need to know about. The changes are purely internal to the keychain UI.

  3. No documented behavior changes: The existing documentation doesn't describe swap detection mechanisms. The docs mention:

    • Layerswap for cross-chain bridging (in starter-packs.md and coinbase-onramp.md)
    • Session policies for transaction approval (in sessions.md)
    • But nothing about internal transaction detection or DEX integrations
  4. Enhanced UX, not new feature: This PR improves how existing swap transactions are displayed in the UI. Users already perform swaps through these DEXes; the PR just makes the Controller better at recognizing and presenting them.

  5. Example code only: The changes to examples/next/src/components/Swap.tsx are just test examples showing different swap patterns - not meant for user documentation.

Conclusion: This is an internal refactoring and enhancement that doesn't affect the documented user-facing API or configuration. The documentation remains accurate and complete without any updates.

--- | Branch: claude/pr-2493-20260324-1705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants