Skip to content

fix(keychain): restore back button on verification pages#2495

Merged
broody merged 1 commit intomainfrom
fix/verification-back-button
Mar 18, 2026
Merged

fix(keychain): restore back button on verification pages#2495
broody merged 1 commit intomainfrom
fix/verification-back-button

Conversation

@broody
Copy link
Contributor

@broody broody commented Mar 18, 2026

Summary

  • Remove setShowClose(true) from Verification and StripeVerification components that was overriding the back button with close even when navigation history existed
  • Remove showClose: true option from verification navigation in OnchainCheckout

Test plan

  • Open onchain starterpack purchase flow
  • Navigate to identity verification (Apple Pay or Stripe)
  • Verify back button appears instead of close button
  • Verify back button navigates back to checkout

🤖 Generated with Claude Code

…ases

Remove setShowClose(true) from verification components that was
overriding the back button with close even when navigation history
existed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Mar 18, 2026 9:32pm
keychain Ready Ready Preview Mar 18, 2026 9:32pm
keychain-storybook Ready Ready Preview Mar 18, 2026 9:32pm

Request Review

@claude
Copy link
Contributor

claude bot commented Mar 18, 2026

Claude finished @broody's task —— View job


Documentation Analysis Complete

Task: Analyze PR #2495 changes and update docs if user-facing behavior changed.

Checklist:

  • Analyze the nature of the change (bug fix vs feature change)
  • Search docs repo for relevant purchase/verification flow documentation
  • Determine if documentation updates are needed
  • Make updates if necessary, or state why none are needed

Analysis:

The PR fixed a bug in the keychain's verification flow where:

  • Verification pages were incorrectly showing a close button instead of a back button
  • This occurred even when navigation history existed that users could navigate back to
  • The fix removes the override that was forcing the close button

Documentation Review:

I reviewed docs-repo/src/pages/controller/starter-packs.md which documents the purchase flow. Line 169 states:

Identity Verification (Stripe only): First-time Stripe users must verify their identity by providing first name, last name, and phone number. Verified users skip directly to payment.

The documentation describes the verification step but does not specify UI details like button behavior (back vs close).

Decision: No Documentation Updates Required

Reasoning:

  1. Bug fix, not feature change: This PR restores the intended navigation behavior (back button) rather than changing the specification
  2. Implementation detail: The back vs. close button behavior is a UI implementation detail, not part of the user-facing API or flow specification
  3. Documentation doesn't specify button behavior: The existing documentation describes what happens during verification (providing identity info) but doesn't document specific UI elements like buttons
  4. DEFAULT TO NO CHANGES: Following the directive to default to no changes, especially since this is an internal UI bug fix

The documentation correctly describes the verification flow itself. The button behavior is an internal UI concern that doesn't affect the documented API or user flow.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant